The filename is being generated using the Avro fullname ($name), but the class name inside the file is generated using the short name ($registeredSchema->name()). This mismatch will break PSR-4 autoloading. Additionally, ucwords on a fullname containing dots (e.g., com.example.User) will not produce a valid filename or directory structure as intended. You should use the short name for the filename to match the class name, especially since all classes are being placed in the same PHP namespace.

                $filename = $path.'/'.ucwords($registeredSchema->name()).'.php';

The class Node\ArrayItem does not exist in php-parser. Based on your other usages of the Node\Expr namespace in this file, this should be Node\Expr\ArrayItem. This will cause a runtime error when generating code for records with fields.

            $arrayItems[] = new Node\Expr\ArrayItem(
                $this->buildJsonSerializeValue($field->type(), $field->name()),
                new String_($field->name())
            );

Using indented flexible heredocs with empty lines can be fragile. In PHP, every line within the heredoc must have at least the same indentation as the closing identifier. If the 'empty' lines (81, 83, 85) do not contain the exact number of spaces as the closing PHP; tag, a ParseError will occur. It is safer to use a non-indented heredoc or ensure the empty lines are properly padded, though the former is much more maintainable.

The jsonSerialize logic correctly handles single Enum fields by accessing the ->value property, but it does not handle collections (arrays or maps) of Enums. Since the generated Enums are Backed Enums and do not implement JsonSerializable, json_encode will not automatically convert them to their string values when they are nested in arrays or maps. This will result in invalid Avro JSON output for schemas containing collections of enums.

⚠️ Potential issue | 🟡 Minor

ucwords() may produce unexpected results for namespaced schema names.

ucwords($name) capitalizes the first letter of each word (space-delimited by default). For Avro fullnames like com.example.User, this produces Com.example.user.php instead of the expected User.php. The registry key is the fullname, but the file should use only the simple name.

Consider using $registeredSchema->name() (the simple name) instead of the fullname for the filename:

-                $filename = $path.'/'.ucwords($name).'.php';
+                $filename = $path.'/'.ucfirst($registeredSchema->name()).'.php';

Verify each finding against the current code and only fix it if needed.

In `@lang/php/lib/Generator/AvroCodeGenerator.php` around lines 88 - 89, The
filename generation currently uses ucwords($name) where $name is the fullname
(e.g., "com.example.User"), which produces incorrect filenames for namespaced
schemas; update the code in AvroCodeGenerator.php to use the schema's simple
name (e.g., $registeredSchema->name()) when building $filename so that
$files[$filename] contains the correct file path (ucwords can be removed or
applied to the simple name if desired) and ensure the registry key can remain
the fullname in $name.

⚠️ Potential issue | 🟡 Minor

Potential enum case name collision when symbols differ only by case.

strtoupper($value) will produce identical case names for symbols like ["red", "RED"] or ["Yes", "YES"], resulting in duplicate enum cases and a PHP parse error in the generated code.

Consider adding a check for collisions or preserving original casing:

+    private function buildEnumCases(array $values): array
+    {
+        $caseNames = [];
+        $statements = [];
+        foreach ($values as $value) {
+            $caseName = strtoupper($value);
+            if (isset($caseNames[$caseName])) {
+                throw new AvroCodeGeneratorException(
+                    sprintf('Enum case collision: "%s" and "%s" both map to "%s"', $caseNames[$caseName], $value, $caseName)
+                );
+            }
+            $caseNames[$caseName] = $value;
+            $statements[] = $this->factory->enumCase($caseName)->setValue($value);
+        }
+        return $statements;
+    }

Verify each finding against the current code and only fix it if needed.

In `@lang/php/lib/Generator/AvroCodeGenerator.php` around lines 273 - 277, The
enum generation uses strtoupper($value) to make $caseName which can collide for
symbols that differ only by case (e.g. "red" vs "RED"); update the logic in
AvroCodeGenerator (the loop building $caseName and calling $enum->addStmt) to
detect duplicate $caseName values before adding cases and handle them
deterministically—either throw a clear error listing the conflicting symbols or
disambiguate by appending a unique suffix/index or using a safer transformation
that preserves uniqueness (e.g., include original chars or an incremental
suffix); ensure the chosen approach prevents duplicate enum cases and that the
error/handling references the original $value strings so generated code remains
valid.

lang/php/lib/Generator/AvroCodeGenerator.php:299: Mapping Avro null to the standalone PHP type null will generate code that does not compile on PHP 8.1 (standalone null types are only allowed starting in PHP 8.2), which conflicts with the package’s php: ^8.1 requirement. This also means the record_with_all_primitive_types expectation currently codifies output that can’t be executed on PHP 8.1.

Severity: high

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

lang/php/lib/Generator/AvroCodeGenerator.php:88: translate() uses the registry key ($name = schema fullname) to form the filename, while the generated class/enum name is based on the unqualified schema name(). For schemas with an Avro namespace, this can produce filenames containing dots / not matching the declared type name, which can break common autoloading expectations.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

lang/php/lib/Generator/AvroCodeGenerator.php:154: Default values are injected without considering the field schema, so defaults for non-scalar typed fields (notably enums and records) will likely emit invalid PHP (e.g., a string default for a property typed as a generated enum). This can cause a fatal error when the generated class is loaded.

Severity: high

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

lang/php/lib/Generator/AvroCodeGenerator.php:194: Generating property/method/parameter names directly from Avro field names can produce invalid PHP in edge cases (e.g., field name colliding with reserved keywords or with generated methods like jsonSerialize / __construct). When that happens, the generated file will fail to parse or will redeclare methods.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

lang/php/lib/Generator/AvroCodeGenerator.php:274: Enum case names are derived via strtoupper($value), which can collapse distinct Avro symbols that differ only by case (e.g., foo vs FOO) into duplicate PHP case identifiers. That would make the generated enum invalid.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

Filename uses fullname instead of simple name

High Severity

The filename at line 88 is built from $name, which is the registry key — i.e., $schema->fullname(). For Avro schemas with a namespace (e.g., "namespace": "com.example"), fullname() returns "com.example.User", producing a filename like Com.example.User.php. Meanwhile, buildRecord and buildEnum derive the class name from $schema->name() (the simple name, "User"). This mismatch means the generated file won't match its class name, breaking autoloading and PSR-4 conventions for any namespaced Avro schema.

 

PHPDoc loses generic types for unions in nested contexts

Low Severity

avroTypeToPhpDocInner delegates to unionToPhp for union schemas, which in turn calls avroTypeToPhp — mapping arrays/maps to the bare 'array' string. This discards generic type information in PHPDoc. For example, a field typed as array<["null", {"type":"array","items":"int"}]> would produce list<null|array> instead of the correct list<null|list<int>>. The union branch here needs to call avroTypeToPhpDocInner on each member instead.

 

Enum case names can collide with PHP reserved words

Medium Severity

strtoupper($value) on valid Avro enum symbols like "null", "true", "false", or "class" produces "NULL", "TRUE", "FALSE", "CLASS" — all reserved identifiers in PHP 8.1+ that cannot be used as enum case names. The generated PHP code would fail to compile for any Avro enum containing these common symbols.